From 634e8ef153637dbc53f99a398ffe6d6380032829 Mon Sep 17 00:00:00 2001 From: George Kankava Date: Thu, 18 Feb 2016 19:39:17 +0400 Subject: [PATCH] Multile code improvements: squid:S1118, squid:S1068 --- src/main/java/io/socket/engineio/client/Socket.java | 5 ----- .../io/socket/engineio/client/transports/PollingXHR.java | 5 ----- src/main/java/io/socket/utf8/UTF8.java | 4 +++- src/main/java/io/socket/yeast/Yeast.java | 4 +++- 4 files changed, 6 insertions(+), 12 deletions(-) diff --git a/src/main/java/io/socket/engineio/client/Socket.java b/src/main/java/io/socket/engineio/client/Socket.java index 91fb75c..767718c 100644 --- a/src/main/java/io/socket/engineio/client/Socket.java +++ b/src/main/java/io/socket/engineio/client/Socket.java @@ -90,11 +90,6 @@ public class Socket extends Emitter { */ public static final String EVENT_TRANSPORT = "transport"; - private static final Runnable noop = new Runnable() { - @Override - public void run() {} - }; - /** * The protocol version. */ diff --git a/src/main/java/io/socket/engineio/client/transports/PollingXHR.java b/src/main/java/io/socket/engineio/client/transports/PollingXHR.java index 864b114..7da6953 100644 --- a/src/main/java/io/socket/engineio/client/transports/PollingXHR.java +++ b/src/main/java/io/socket/engineio/client/transports/PollingXHR.java @@ -19,9 +19,6 @@ public class PollingXHR extends Polling { private static final Logger logger = Logger.getLogger(PollingXHR.class.getName()); - private Request sendXhr; - private Request pollXhr; - public PollingXHR(Transport.Options opts) { super(opts); } @@ -92,7 +89,6 @@ public class PollingXHR extends Polling { } }); req.create(); - this.sendXhr = req; } @Override @@ -129,7 +125,6 @@ public class PollingXHR extends Polling { } }); req.create(); - this.pollXhr = req; } public static class Request extends Emitter { diff --git a/src/main/java/io/socket/utf8/UTF8.java b/src/main/java/io/socket/utf8/UTF8.java index 28a1094..511d478 100644 --- a/src/main/java/io/socket/utf8/UTF8.java +++ b/src/main/java/io/socket/utf8/UTF8.java @@ -8,13 +8,15 @@ import java.util.List; * * @see https://github.com/mathiasbynens/utf8.js */ -public class UTF8 { +public final class UTF8 { private static final String INVALID_CONTINUATION_BYTE = "Invalid continuation byte"; private static int[] byteArray; private static int byteCount; private static int byteIndex; + private UTF8 () {} + public static String encode(String string) throws UTF8Exception { int[] codePoints = ucs2decode(string); int length = codePoints.length; diff --git a/src/main/java/io/socket/yeast/Yeast.java b/src/main/java/io/socket/yeast/Yeast.java index f41bf80..32fd4eb 100644 --- a/src/main/java/io/socket/yeast/Yeast.java +++ b/src/main/java/io/socket/yeast/Yeast.java @@ -7,7 +7,7 @@ import java.util.Map; /** * A Java implementation of yeast. https://github.com/unshiftio/yeast */ -public class Yeast { +public final class Yeast { private static char[] alphabet = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz-_".toCharArray(); private static int length = alphabet.length; @@ -19,6 +19,8 @@ public class Yeast { } } + private Yeast () {} + private static int seed = 0; private static String prev;