h4ckx0r/socket.io-client-java
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Code Quality Improvement - Exception handlers should preserve the original exception

Browse Source 
Update

Update
This commit is contained in:
Christian Ivan
2015-12-03 12:20:29 +07:00
parent 86898db7b1
commit 2143774a1e
4 changed files with 21 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/java/io/socket/client/Socket.java
View File

@@ -10,6 +10,7 @@ import org.json.JSONException;
import org.json.JSONObject; import org.json.JSONObject;
import java.util.*; import java.util.*;
import java.util.logging.Level;
import java.util.logging.Logger; import java.util.logging.Logger;
/** /**
@@ -452,6 +453,7 @@ public class Socket extends Emitter {
try { try {
v = array.get(i); v = array.get(i);
} catch (JSONException e) { } catch (JSONException e) {
logger.log(Level.WARNING, "An error occured while retrieving data from JSONArray", e);
v = null; v = null;
} }
data[i] = v == JSONObject.NULL ? null : v; data[i] = v == JSONObject.NULL ? null : v;

10
src/main/java/io/socket/hasbinary/HasBinary.java
View File

@@ -3,11 +3,15 @@ package io.socket.hasbinary;
import org.json.JSONArray; import org.json.JSONArray;
import org.json.JSONException; import org.json.JSONException;
import org.json.JSONObject; import org.json.JSONObject;
import java.util.logging.Level;
import java.util.logging.Logger;
import java.util.Iterator; import java.util.Iterator;
public class HasBinary { public class HasBinary {
private static final Logger logger = Logger.getLogger(HasBinary.class.getName());
private HasBinary() {} private HasBinary() {}
public static boolean hasBinary(Object data) { public static boolean hasBinary(Object data) {
@@ -29,6 +33,7 @@ public class HasBinary {
try { try {
v = _obj.isNull(i) ? null : _obj.get(i); v = _obj.isNull(i) ? null : _obj.get(i);
} catch (JSONException e) { } catch (JSONException e) {
logger.log(Level.WARNING, "An error occured while retrieving data from JSONArray", e);
return false; return false;
} }
if (_hasBinary(v)) { if (_hasBinary(v)) {
@@ -44,7 +49,8 @@ public class HasBinary {
try { try {
v = _obj.get(key); v = _obj.get(key);
} catch (JSONException e) { } catch (JSONException e) {
return false; logger.log(Level.WARNING, "An error occured while retrieving data from JSONObject", e);
return false;
} }
if (_hasBinary(v)) { if (_hasBinary(v)) {
return true; return true;

10
src/main/java/io/socket/parser/Binary.java
View File

@@ -7,13 +7,16 @@ import org.json.JSONObject;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Iterator; import java.util.Iterator;
import java.util.List; import java.util.List;
import java.util.logging.Level;
import java.util.logging.Logger;
public class Binary { public class Binary {
private static final String KEY_PLACEHOLDER = "_placeholder"; private static final String KEY_PLACEHOLDER = "_placeholder";
private static final String KEY_NUM = "num"; private static final String KEY_NUM = "num";
private static final Logger logger = Logger.getLogger(Binary.class.getName());
public static DeconstructedPacket deconstructPacket(Packet packet) { public static DeconstructedPacket deconstructPacket(Packet packet) {
List<byte[]> buffers = new ArrayList<byte[]>(); List<byte[]> buffers = new ArrayList<byte[]>();
@@ -36,6 +39,7 @@ public class Binary {
placeholder.put(KEY_PLACEHOLDER, true); placeholder.put(KEY_PLACEHOLDER, true);
placeholder.put(KEY_NUM, buffers.size()); placeholder.put(KEY_NUM, buffers.size());
} catch (JSONException e) { } catch (JSONException e) {
logger.log(Level.WARNING, "An error occured while putting data to JSONObject", e);
return null; return null;
} }
buffers.add((byte[])data); buffers.add((byte[])data);
@@ -48,6 +52,7 @@ public class Binary {
try { try {
newData.put(i, _deconstructPacket(_data.get(i), buffers)); newData.put(i, _deconstructPacket(_data.get(i), buffers));
} catch (JSONException e) { } catch (JSONException e) {
logger.log(Level.WARNING, "An error occured while putting packet data to JSONObject", e);
return null; return null;
} }
} }
@@ -61,6 +66,7 @@ public class Binary {
try { try {
newData.put(key, _deconstructPacket(_data.get(key), buffers)); newData.put(key, _deconstructPacket(_data.get(key), buffers));
} catch (JSONException e) { } catch (JSONException e) {
logger.log(Level.WARNING, "An error occured while putting data to JSONObject", e);
return null; return null;
} }
} }
@@ -83,6 +89,7 @@ public class Binary {
try { try {
_data.put(i, _reconstructPacket(_data.get(i), buffers)); _data.put(i, _reconstructPacket(_data.get(i), buffers));
} catch (JSONException e) { } catch (JSONException e) {
logger.log(Level.WARNING, "An error occured while putting packet data to JSONObject", e);
return null; return null;
} }
} }
@@ -99,6 +106,7 @@ public class Binary {
try { try {
_data.put(key, _reconstructPacket(_data.get(key), buffers)); _data.put(key, _reconstructPacket(_data.get(key), buffers));
} catch (JSONException e) { } catch (JSONException e) {
logger.log(Level.WARNING, "An error occured while putting data to JSONObject", e);
return null; return null;
} }
} }

2
src/main/java/io/socket/parser/Parser.java
View File

@@ -7,6 +7,7 @@ import org.json.JSONTokener;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Arrays; import java.util.Arrays;
import java.util.List; import java.util.List;
import java.util.logging.Level;
import java.util.logging.Logger; import java.util.logging.Logger;
public class Parser { public class Parser {
@@ -227,6 +228,7 @@ public class Parser {
str.charAt(++i); str.charAt(++i);
p.data = new JSONTokener(str.substring(i)).nextValue(); p.data = new JSONTokener(str.substring(i)).nextValue();
} catch (JSONException e) { } catch (JSONException e) {
logger.log(Level.WARNING, "An error occured while retrieving data from JSONTokener", e);
return error(); return error();
} }
} }