h4ckx0r/socket.io-client-java
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add condition to log only if fine level is loggable

Browse Source 
Even if FINE level is not loggable String.format() works every time and
tries to format string with all the events. Sometimes it causes
OutOfMemory exceptions.
This commit is contained in:
Sergey Davydov
2017-05-28 13:01:18 +03:00
parent 8f8c138a61
commit 229a820bf5
4 changed files with 46 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/main/java/io/socket/client/IO.java
View File

@@ -3,6 +3,7 @@ package io.socket.client;
import io.socket.parser.Parser;
import java.util.logging.Level;
import javax.net.ssl.HostnameVerifier;
import javax.net.ssl.SSLContext;
import java.net.URI;
@@ -72,11 +73,15 @@ public class IO {
Manager io;
if (newConnection) {
logger.fine(String.format("ignoring socket cache for %s", source));
if (logger.isLoggable(Level.FINE)) {
logger.fine(String.format("ignoring socket cache for %s", source));
}
io = new Manager(source, opts);
} else {
if (!managers.containsKey(id)) {
logger.fine(String.format("new io instance for %s", source));
if (logger.isLoggable(Level.FINE)) {
logger.fine(String.format("new io instance for %s", source));
}
managers.putIfAbsent(id, new Manager(source, opts));
}
io = managers.get(id);