diff --git a/README.md b/README.md index a7c8718..05d07eb 100644 --- a/README.md +++ b/README.md @@ -21,7 +21,7 @@ Add the following dependency to your `pom.xml`. io.socket socket.io-client - 0.8.3 + 0.9.0 ``` @@ -30,7 +30,7 @@ Add the following dependency to your `pom.xml`. Add it as a gradle dependency for Android Studio, in `build.gradle`: ```groovy -compile ('io.socket:socket.io-client:0.8.3') { +compile ('io.socket:socket.io-client:0.9.0') { // excluding org.json which is provided by Android exclude group: 'org.json', module: 'json' } @@ -131,8 +131,8 @@ OkHttpClient okHttpClient = new OkHttpClient.Builder() .build(); // default settings for all sockets -Socket.setDefaultOkHttpWebSocketFactory(okHttpClient); -Socket.setDefaultOkHttpCallFactory(okHttpClient); +IO.setDefaultOkHttpWebSocketFactory(okHttpClient); +IO.setDefaultOkHttpCallFactory(okHttpClient); // set as an option opts = new IO.Options(); diff --git a/src/main/java/io/socket/client/IO.java b/src/main/java/io/socket/client/IO.java index 07aa46c..6dd9758 100644 --- a/src/main/java/io/socket/client/IO.java +++ b/src/main/java/io/socket/client/IO.java @@ -6,6 +6,7 @@ import okhttp3.Call; import okhttp3.OkHttpClient; import okhttp3.WebSocket; +import java.util.logging.Level; import javax.net.ssl.HostnameVerifier; import javax.net.ssl.SSLContext; import java.net.URI; @@ -75,11 +76,15 @@ public class IO { Manager io; if (newConnection) { - logger.fine(String.format("ignoring socket cache for %s", source)); + if (logger.isLoggable(Level.FINE)) { + logger.fine(String.format("ignoring socket cache for %s", source)); + } io = new Manager(source, opts); } else { if (!managers.containsKey(id)) { - logger.fine(String.format("new io instance for %s", source)); + if (logger.isLoggable(Level.FINE)) { + logger.fine(String.format("new io instance for %s", source)); + } managers.putIfAbsent(id, new Manager(source, opts)); } io = managers.get(id); diff --git a/src/main/java/io/socket/client/Manager.java b/src/main/java/io/socket/client/Manager.java index ba5e35a..026e0a0 100644 --- a/src/main/java/io/socket/client/Manager.java +++ b/src/main/java/io/socket/client/Manager.java @@ -259,10 +259,14 @@ public class Manager extends Emitter { EventThread.exec(new Runnable() { @Override public void run() { - logger.fine(String.format("readyState %s", Manager.this.readyState)); + if (logger.isLoggable(Level.FINE)) { + logger.fine(String.format("readyState %s", Manager.this.readyState)); + } if (Manager.this.readyState == ReadyState.OPEN || Manager.this.readyState == ReadyState.OPENING) return; - logger.fine(String.format("opening %s", Manager.this.uri)); + if (logger.isLoggable(Level.FINE)) { + logger.fine(String.format("opening %s", Manager.this.uri)); + } Manager.this.engine = new Engine(Manager.this.uri, Manager.this.opts); final io.socket.engineio.client.Socket socket = Manager.this.engine; final Manager self = Manager.this; @@ -467,7 +471,9 @@ public class Manager extends Emitter { } /*package*/ void packet(Packet packet) { - logger.fine(String.format("writing packet %s", packet)); + if (logger.isLoggable(Level.FINE)) { + logger.fine(String.format("writing packet %s", packet)); + } final Manager self = this; if (packet.query != null && !packet.query.isEmpty() && packet.type == Parser.CONNECT) { diff --git a/src/main/java/io/socket/client/Socket.java b/src/main/java/io/socket/client/Socket.java index 5edfbfa..6aed091 100644 --- a/src/main/java/io/socket/client/Socket.java +++ b/src/main/java/io/socket/client/Socket.java @@ -262,7 +262,9 @@ public class Socket extends Emitter { } private void onclose(String reason) { - logger.fine(String.format("close (%s)", reason)); + if (logger.isLoggable(Level.FINE)) { + logger.fine(String.format("close (%s)", reason)); + } this.connected = false; this.id = null; this.emit(EVENT_DISCONNECT, reason); @@ -316,7 +318,9 @@ public class Socket extends Emitter { private void onevent(Packet packet) { List args = new ArrayList(Arrays.asList(toArray(packet.data))); - logger.fine(String.format("emitting event %s", args)); + if (logger.isLoggable(Level.FINE)) { + logger.fine(String.format("emitting event %s", args)); + } if (packet.id >= 0) { logger.fine("attaching ack callback to event"); @@ -343,7 +347,9 @@ public class Socket extends Emitter { public void run() { if (sent[0]) return; sent[0] = true; - logger.fine(String.format("sending ack %s", args.length != 0 ? args : null)); + if (logger.isLoggable(Level.FINE)) { + logger.fine(String.format("sending ack %s", args.length != 0 ? args : null)); + } JSONArray jsonArgs = new JSONArray(); for (Object arg : args) { @@ -362,10 +368,14 @@ public class Socket extends Emitter { private void onack(Packet packet) { Ack fn = this.acks.remove(packet.id); if (fn != null) { - logger.fine(String.format("calling ack %s with %s", packet.id, packet.data)); + if (logger.isLoggable(Level.FINE)) { + logger.fine(String.format("calling ack %s with %s", packet.id, packet.data)); + } fn.call(toArray(packet.data)); } else { - logger.fine(String.format("bad ack %s", packet.id)); + if (logger.isLoggable(Level.FINE)) { + logger.fine(String.format("bad ack %s", packet.id)); + } } } @@ -391,7 +401,9 @@ public class Socket extends Emitter { } private void ondisconnect() { - logger.fine(String.format("server disconnect (%s)", this.nsp)); + if (logger.isLoggable(Level.FINE)) { + logger.fine(String.format("server disconnect (%s)", this.nsp)); + } this.destroy(); this.onclose("io server disconnect"); } @@ -418,7 +430,9 @@ public class Socket extends Emitter { @Override public void run() { if (Socket.this.connected) { - logger.fine(String.format("performing disconnect (%s)", Socket.this.nsp)); + if (logger.isLoggable(Level.FINE)) { + logger.fine(String.format("performing disconnect (%s)", Socket.this.nsp)); + } Socket.this.packet(new Packet(Parser.DISCONNECT)); } diff --git a/src/main/java/io/socket/parser/IOParser.java b/src/main/java/io/socket/parser/IOParser.java index 787d35a..813c16c 100644 --- a/src/main/java/io/socket/parser/IOParser.java +++ b/src/main/java/io/socket/parser/IOParser.java @@ -1,6 +1,5 @@ package io.socket.parser; -import io.socket.client.IO; import io.socket.hasbinary.HasBinary; import org.json.JSONException; import org.json.JSONTokener; @@ -31,7 +30,9 @@ final public class IOParser implements Parser { obj.type = obj.type == EVENT ? BINARY_EVENT : BINARY_ACK; } - logger.fine(String.format("encoding packet %s", obj)); + if (logger.isLoggable(Level.FINE)) { + logger.fine(String.format("encoding packet %s", obj)); + } if (BINARY_EVENT == obj.type || BINARY_ACK == obj.type) { encodeAsBinary(obj, callback); @@ -62,7 +63,9 @@ final public class IOParser implements Parser { str.append(obj.data); } - logger.fine(String.format("encoded %s as %s", obj, str)); + if (logger.isLoggable(Level.FINE)) { + logger.fine(String.format("encoded %s as %s", obj, str)); + } return str.toString(); } @@ -182,7 +185,9 @@ final public class IOParser implements Parser { } } - logger.fine(String.format("decoded %s as %s", str, p)); + if (logger.isLoggable(Level.FINE)) { + logger.fine(String.format("decoded %s as %s", str, p)); + } return p; } diff --git a/src/main/java/io/socket/parser/Parser.java b/src/main/java/io/socket/parser/Parser.java index b4808b0..66367d5 100644 --- a/src/main/java/io/socket/parser/Parser.java +++ b/src/main/java/io/socket/parser/Parser.java @@ -1,16 +1,5 @@ package io.socket.parser; -import io.socket.emitter.Emitter; -import io.socket.hasbinary.HasBinary; -import org.json.JSONException; -import org.json.JSONTokener; - -import java.util.ArrayList; -import java.util.Arrays; -import java.util.List; -import java.util.logging.Level; -import java.util.logging.Logger; - public interface Parser { /**