h4ckx0r/socket.io-client-java
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #259 from DevFactory/release/collection-isempty-fix-1

Browse Source 
Code Quality Improvement - Collection.isEmpty() should be used to test for emptiness
This commit is contained in:
Naoyuki Kanezawa
2015-12-18 11:51:44 +09:00
parent 1ef3b2cae7 d364404501
commit a3f2b8cd00
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/main/java/io/socket/client/Manager.java
View File

@@ -416,7 +416,7 @@ public class Manager extends Emitter {
/*package*/ void destroy(Socket socket) { /*package*/ void destroy(Socket socket) {
this.connected.remove(socket); this.connected.remove(socket);
if (this.connected.size() > 0) return; if (!this.connected.isEmpty()) return;
this.close(); this.close();
} }
@@ -447,7 +447,7 @@ public class Manager extends Emitter {
} }
private void processPacketQueue() { private void processPacketQueue() {
if (this.packetBuffer.size() > 0 && !this.encoding) { if (!this.packetBuffer.isEmpty() && !this.encoding) {
Packet pack = this.packetBuffer.remove(0); Packet pack = this.packetBuffer.remove(0);
this.packet(pack); this.packet(pack);
} }

2
src/main/java/io/socket/client/Socket.java
View File

@@ -325,7 +325,7 @@ public class Socket extends Emitter {
} }
if (this.connected) { if (this.connected) {
if (args.size() == 0) return; if (args.isEmpty()) return;
String event = args.remove(0).toString(); String event = args.remove(0).toString();
super.emit(event, args.toArray()); super.emit(event, args.toArray());
} else { } else {