From bc45e15d034cf2900d3874bf00e820d0f0a28c6e Mon Sep 17 00:00:00 2001 From: nkzawa Date: Sun, 13 Dec 2015 02:52:55 +0900 Subject: [PATCH] suppress cast warnings --- src/main/java/io/socket/client/Socket.java | 32 +++++++++++++++------- src/test/java/io/socket/util/Optional.java | 4 +-- 2 files changed, 24 insertions(+), 12 deletions(-) diff --git a/src/main/java/io/socket/client/Socket.java b/src/main/java/io/socket/client/Socket.java index 88f897e..45f3759 100644 --- a/src/main/java/io/socket/client/Socket.java +++ b/src/main/java/io/socket/client/Socket.java @@ -98,7 +98,7 @@ public class Socket extends Emitter { add(On.on(io, Manager.EVENT_PACKET, new Listener() { @Override public void call(Object... args) { - Socket.this.onpacket((Packet) args[0]); + Socket.this.onpacket((Packet) args[0]); } })); add(On.on(io, Manager.EVENT_CLOSE, new Listener() { @@ -268,7 +268,7 @@ public class Socket extends Emitter { this.emit(EVENT_DISCONNECT, reason); } - private void onpacket(Packet packet) { + private void onpacket(Packet packet) { if (!this.nsp.equals(packet.nsp)) return; switch (packet.type) { @@ -276,21 +276,33 @@ public class Socket extends Emitter { this.onconnect(); break; - case Parser.EVENT: - this.onevent(packet); + case Parser.EVENT: { + @SuppressWarnings("unchecked") + Packet p = (Packet) packet; + this.onevent(p); break; + } - case Parser.BINARY_EVENT: - this.onevent(packet); + case Parser.BINARY_EVENT: { + @SuppressWarnings("unchecked") + Packet p = (Packet) packet; + this.onevent(p); break; + } - case Parser.ACK: - this.onack(packet); + case Parser.ACK: { + @SuppressWarnings("unchecked") + Packet p = (Packet) packet; + this.onack(p); break; + } - case Parser.BINARY_ACK: - this.onack(packet); + case Parser.BINARY_ACK: { + @SuppressWarnings("unchecked") + Packet p = (Packet) packet; + this.onack(p); break; + } case Parser.DISCONNECT: this.ondisconnect(); diff --git a/src/test/java/io/socket/util/Optional.java b/src/test/java/io/socket/util/Optional.java index b9f5023..aadc603 100644 --- a/src/test/java/io/socket/util/Optional.java +++ b/src/test/java/io/socket/util/Optional.java @@ -4,7 +4,7 @@ import java.util.NoSuchElementException; public class Optional { - static final Optional EMPTY = Optional.ofNullable(null); + static final Optional EMPTY = Optional.ofNullable(null); private T value; @@ -19,7 +19,7 @@ public class Optional { return new Optional(value); } - public static Optional empty() { + public static Optional empty() { return EMPTY; }