From d3644045011ebeac19e580f4c123e1ff8966d394 Mon Sep 17 00:00:00 2001 From: Christian Ivan Date: Wed, 2 Dec 2015 17:17:46 +0700 Subject: [PATCH] Code Quality Improvement - Collection.isEmpty() should be used to test for emptiness --- src/main/java/io/socket/client/Manager.java | 4 ++-- src/main/java/io/socket/client/Socket.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/io/socket/client/Manager.java b/src/main/java/io/socket/client/Manager.java index b5cd07c..8fb7209 100644 --- a/src/main/java/io/socket/client/Manager.java +++ b/src/main/java/io/socket/client/Manager.java @@ -416,7 +416,7 @@ public class Manager extends Emitter { /*package*/ void destroy(Socket socket) { this.connected.remove(socket); - if (this.connected.size() > 0) return; + if (!this.connected.isEmpty()) return; this.close(); } @@ -447,7 +447,7 @@ public class Manager extends Emitter { } private void processPacketQueue() { - if (this.packetBuffer.size() > 0 && !this.encoding) { + if (!this.packetBuffer.isEmpty() && !this.encoding) { Packet pack = this.packetBuffer.remove(0); this.packet(pack); } diff --git a/src/main/java/io/socket/client/Socket.java b/src/main/java/io/socket/client/Socket.java index 88f897e..f43a4c2 100644 --- a/src/main/java/io/socket/client/Socket.java +++ b/src/main/java/io/socket/client/Socket.java @@ -312,7 +312,7 @@ public class Socket extends Emitter { } if (this.connected) { - if (args.size() == 0) return; + if (args.isEmpty()) return; String event = args.remove(0).toString(); super.emit(event, args.toArray()); } else {