diff --git a/src/main/java/io/socket/client/Manager.java b/src/main/java/io/socket/client/Manager.java index a3c5f19..0419899 100644 --- a/src/main/java/io/socket/client/Manager.java +++ b/src/main/java/io/socket/client/Manager.java @@ -72,20 +72,20 @@ public class Manager extends Emitter { private long _reconnectionDelay; private long _reconnectionDelayMax; private double _randomizationFactor; - private Backoff backoff; + private final Backoff backoff; private long _timeout; - private URI uri; - private List packetBuffer; - private Queue subs; - private Options opts; + private final URI uri; + private final List packetBuffer = new ArrayList<>(); + private final Queue subs = new LinkedList<>();; + private final Options opts; /*package*/ io.socket.engineio.client.Socket engine; - private Parser.Encoder encoder; - private Parser.Decoder decoder; + private final Parser.Encoder encoder; + private final Parser.Decoder decoder; /** * This HashMap can be accessed from outside of EventThread. */ - /*package*/ ConcurrentHashMap nsps; + /*package*/ final Map nsps = new ConcurrentHashMap<>(); public Manager() { @@ -114,8 +114,6 @@ public class Manager extends Emitter { opts.callFactory = defaultCallFactory; } this.opts = opts; - this.nsps = new ConcurrentHashMap<>(); - this.subs = new LinkedList<>(); this.reconnection(opts.reconnection); this.reconnectionAttempts(opts.reconnectionAttempts != 0 ? opts.reconnectionAttempts : Integer.MAX_VALUE); this.reconnectionDelay(opts.reconnectionDelay != 0 ? opts.reconnectionDelay : 1000); @@ -129,7 +127,6 @@ public class Manager extends Emitter { this.readyState = ReadyState.CLOSED; this.uri = uri; this.encoding = false; - this.packetBuffer = new ArrayList<>(); this.encoder = opts.encoder != null ? opts.encoder : new IOParser.Encoder(); this.decoder = opts.decoder != null ? opts.decoder : new IOParser.Decoder(); } diff --git a/src/main/java/io/socket/client/Socket.java b/src/main/java/io/socket/client/Socket.java index bfcb2ad..eccf09c 100644 --- a/src/main/java/io/socket/client/Socket.java +++ b/src/main/java/io/socket/client/Socket.java @@ -57,23 +57,21 @@ public class Socket extends Emitter { private volatile boolean connected; private int ids; - private String nsp; - private Manager io; - private Map auth; - private Map acks = new ConcurrentHashMap<>(); + private final String nsp; + private final Manager io; + private final Map auth; + private final Map acks = new ConcurrentHashMap<>(); private Queue subs; private final Queue> receiveBuffer = new ConcurrentLinkedQueue<>(); private final Queue> sendBuffer = new ConcurrentLinkedQueue<>(); - private ConcurrentLinkedQueue onAnyIncomingListeners = new ConcurrentLinkedQueue<>(); - private ConcurrentLinkedQueue onAnyOutgoingListeners = new ConcurrentLinkedQueue<>(); + private final ConcurrentLinkedQueue onAnyIncomingListeners = new ConcurrentLinkedQueue<>(); + private final ConcurrentLinkedQueue onAnyOutgoingListeners = new ConcurrentLinkedQueue<>(); public Socket(Manager io, String nsp, Manager.Options opts) { this.io = io; this.nsp = nsp; - if (opts != null) { - this.auth = opts.auth; - } + this.auth = opts != null ? opts.auth : null; } private void subEvents() {